Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable zoom and link for default "No Image" image. #1291

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Disable zoom and link for default "No Image" image. #1291

merged 1 commit into from
Jun 28, 2018

Conversation

Ubersmake
Copy link
Contributor

@Ubersmake Ubersmake commented Jun 28, 2018

What?

A revert of the revert (#1279) of #1278. There are some slight changes between product-view.html in this and #1278, with the goal of this PR to keep as much information on the rendered page as possible.

The vast majority of this description is copied over from #1278.

When a product has no images Cornerstone will display a default "No Image" image.

This image is zoomable, like other product images. And the image technically exists within an element.

This PR removes that behavior. If a product has no images and thus displays the "No Image" image, the "No Image" image is treated like placeholder text. It does not zoom. It has no href.

As a caveat, it is possible for a product to have no image, but for its variants to have images. In this specific case the zoom behavior is removed from both the "No Image" image and any images associated with variants. There is no workaround for this at this time.

Products with images with some but not all variants with images were never affected.

Diff for product-view.html between this PR and the commit in #1278: Diff

Tickets / Documentation

Screenshots (if appropriate)

Before

Product Details Page:

productbefore

Quick View:

quickbefore

Product Details Page, No Main Image, One Variant with Image:

220-nomainimage

After

Product Details Page:

productafter

Quick View:

quickafter

Product Details Page, No Main Image, One Variant with Image:

pr-nomainimage

@bigbot
Copy link

bigbot commented Jun 28, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@Ubersmake Ubersmake merged commit b2b5f6a into bigcommerce:master Jun 28, 2018
@Ubersmake Ubersmake deleted the STRF-5007 branch June 28, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants